Revert change to delta filter #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
==========================================
- Coverage 99.70% 99.70% -0.01%
==========================================
Files 62 62
Lines 2753 2751 -2
==========================================
- Hits 2745 2743 -2
Misses 8 8
🚀 New features to boost your workflow:
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #584, as it has caused two issues so far, one of which is unresolved: #653 and #595.
There is a proposed fix at #657, but that is held up under review.
In order to un-break zarr-python, I think reverting here is the right thing to do (so we can do a 0.15 release with other stuff).
My intention is to add a test to #653 to this PR too, so keeping as draft. Opening so there's time for folks to see that I'm intending to do this; cc @jakirkham @ehgus